feat: transaction text prop by lissavxo · Pull Request #471 · PayButton/paybutton

lissavxo · 2025-03-18T15:02:00Z

Related to #270

Description

Added the transaction-text prop. The transaction-text will be displayed in the widget when a transaction occurs, but the amount does not match the required amount, preventing a success message.

Test plan

Add transaction-text prop in a paybutton and widget
Test transact-text in paybutton generator

Klakurka

Can you update one of the examples in the demo page to use this? Perhaps on the XEC 'Purchase' button that already has a success-text set.
Let's go ahead and open a PR on the server to get the button generator updated. We can update the wordpress plugin later.

Klakurka · 2025-03-20T13:48:40Z

react/lib/components/Widget/WidgetContainer.tsx

+              setTimeout(() => {
+                setNewTxText('')
+              }, 10000)
+            }


I wasn't really expecting this... I think it's better to stick with the standard toast and perhaps we can make a new task to better differentiate them so people don't mistakenly think they paid the full correct amount when they did not.

On second thought - @chedieck thoughts on this? Maybe John also has some ideas how best to visually communicate the custom message while also making it clear that less than the full amount was paid.

Maybe call it "Unexpected payment" or something like that by default? Probably some other more precise adjective would be better.

As for the PR, this 10000 should be a constant instead of a hardcoded number.

chedieck · 2025-03-21T15:03:55Z

react/lib/components/Widget/WidgetContainer.tsx

+              setTimeout(() => {
+                setNewTxText('')
+              }, 10000)
+            }


Maybe call it "Unexpected payment" or something like that by default? Probably some other more precise adjective would be better.

As for the PR, this 10000 should be a constant instead of a hardcoded number.

Klakurka

I tried to send the wrong amount to a widget and wasn't able to get the tx to appear. I even entered the op_return_raw for it but still nothing.

Klakurka · 2025-04-08T02:45:41Z

react/lib/components/Widget/WidgetContainer.tsx

+            if (transactionText){
+              enqueueSnackbar(
+                `${
+                  transactionText ? transactionText : 'New transaction'


I don't think this should be set by default.

Let's keep the old behaviour (of no toast) if it's not set.

it is already set to only trigger the toast if there is a transaction text set

Klakurka · 2025-04-08T02:47:33Z

docs/README.md


+## transaction-text
+
+> **The ‘transaction-text’ parameter specifies the text displayed when a new transaction occurs.**


Let's clarify that it's displayed when a new transaction is received that doesn't have the correct amount & OP_RETURN code.

On BCH we just check that it's the correct amount as OP_RETURN is not really supported well on the wallet side.

Klakurka · 2025-04-08T02:47:56Z

docs/zh-cn/README.md


+## transaction-text
+
+> **“transaction-text” 参数指定在新交易发生时显示的文本。**


Update as needed.

Klakurka · 2025-04-08T02:47:59Z

docs/zh-tw/README.md


+## transaction-text
+
+> **"transaction-text" 參數指定在新交易發生時顯示的文字。**


Update as needed.

Klakurka · 2025-04-08T02:49:20Z

We'll be adding support for BIP 70 in the near future so this feature may end up being obsolete in most cases.

Klakurka · 2025-04-17T16:29:54Z

Conflicts.

lissavxo · 2025-04-17T16:59:30Z

Conflicts.

resolved

chedieck

Nothing is appearing to me now.

Tried with

    <div class="paybutton" to="ecash:qq3zv9s3jna6x5t0fxzfgd2zwteqyyjrscf9zmthz7" text="Mine" amount="21"
      currency="XEC" goal-amount="1000" success-text="WOW!" on-close="myClose" on-open="myOpen"
      on-success="mySuccessFunction" on-transaction="myTransactionFunction" 
                                                                            transaction-text="fooo"></div>

chedieck

Working well

Klakurka

I actually couldn't get this to work.

My steps:

Update dev/demo/index.html, adding transaction-text="partial payment" to the Basic button.
Open http://localhost:10001/
Click the Basic button to open the QR code.
Click the QR code to copy the BIP21 URI. Paste the URI somewhere and edit out the amount. Copy the URI without the amount.
Open https://cashtab.com/ and paste the URI into the address field.
Enter an amount of 8 (or something that isn't 10).
Click Send.

When I follow these steps, nothing happens.

Klakurka requested a review from chedieck March 19, 2025 01:56

lissavxo requested a review from Klakurka March 19, 2025 13:35

lissavxo force-pushed the feat/transaction-text branch from 6524dc6 to 658e370 Compare March 19, 2025 19:50

Klakurka requested changes Mar 20, 2025

View reviewed changes

chedieck requested changes Mar 21, 2025

View reviewed changes

Klakurka requested changes Apr 6, 2025

View reviewed changes

Klakurka requested changes Apr 8, 2025

View reviewed changes

lissavxo requested review from Klakurka and chedieck April 9, 2025 16:34

lissavxo force-pushed the feat/transaction-text branch from 8492963 to 8a67599 Compare April 9, 2025 17:19

lissavxo force-pushed the feat/transaction-text branch from 8a67599 to fa9f2d1 Compare April 17, 2025 16:58

chedieck requested changes Apr 30, 2025

View reviewed changes

lissavxo added 4 commits April 30, 2025 11:22

feat: transaction text prop

2b10a4e

docs: transaction-text prop

750a7d4

fix: transaction text

d9b1db5

docs: transaction-text

3dba7d9

lissavxo force-pushed the feat/transaction-text branch from fa9f2d1 to 3dba7d9 Compare April 30, 2025 14:23

chedieck approved these changes May 5, 2025

View reviewed changes

Klakurka requested changes May 17, 2025

View reviewed changes

Klakurka approved these changes May 22, 2025

View reviewed changes

Klakurka merged commit e0bb16c into master May 22, 2025
1 check passed


		## transaction-text

		> The ‘transaction-text’ parameter specifies the text displayed when a new transaction occurs.


		## transaction-text

		> “transaction-text” 参数指定在新交易发生时显示的文本。


		## transaction-text

		> "transaction-text" 參數指定在新交易發生時顯示的文字。

Conversation

lissavxo commented Mar 18, 2025

Description

Test plan

Uh oh!

Klakurka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Klakurka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Klakurka commented Apr 8, 2025

Uh oh!

Klakurka commented Apr 17, 2025

Uh oh!

lissavxo commented Apr 17, 2025

Uh oh!

chedieck left a comment

Choose a reason for hiding this comment

Uh oh!

chedieck left a comment

Choose a reason for hiding this comment

Uh oh!

Klakurka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants